Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the expected prefund token type to account create output #2328

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

integraledelebesgue
Copy link
Member

@integraledelebesgue integraledelebesgue commented Jul 22, 2024

Closes #2247

Introduced changes

  • account create now outputs information about the expected type of tokens needed to prefund a newly created account with
  • documentation explains it too

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@integraledelebesgue integraledelebesgue requested review from piotmag769 and ksew1 and removed request for tomek0123456789, Arcticae and ksew1 July 22, 2024 11:13
@integraledelebesgue integraledelebesgue changed the title Integraledelebesgue/fix 2247 Added the expected prefund token type to account create output Jul 22, 2024
@integraledelebesgue integraledelebesgue linked an issue Jul 22, 2024 that may be closed by this pull request
@piotmag769 piotmag769 removed their request for review July 22, 2024 12:03
Copy link
Collaborator

@ksew1 ksew1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@integraledelebesgue integraledelebesgue added this pull request to the merge queue Jul 29, 2024
Merged via the queue into master with commit 81ddfc3 Jul 29, 2024
13 checks passed
@integraledelebesgue integraledelebesgue deleted the integraledelebesgue/fix-2247 branch July 29, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify which tokens to prefund the account with
2 participants