Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type update: Allow optional ApplicationWindowConfiguration controls #18400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DFreds
Copy link
Contributor

@DFreds DFreds commented Mar 4, 2025

No description provided.

@stwlam
Copy link
Collaborator

stwlam commented Mar 7, 2025

Really these should all be required, with DEFAULT_OPTIONS the constructor options being partials.

@DFreds
Copy link
Contributor Author

DFreds commented Mar 8, 2025

Really these should all be required, with DEFAULT_OPTIONS the constructor options being partials.

So, make ApplicationConfiguration have window: Partial<ApplicationWindowConfiguration>? I can make that change if so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants