-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Class Archetype tags, add Flexible Spellcasting as a level 1 option for eligible classes and update Flexible Spellcasting journal entry #18528
base: master
Are you sure you want to change the base?
Conversation
"predicate": [ | ||
{ | ||
"not": "class:wizard" | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can (and should) do this cleaner in a single ChoiceSet instead of having two with the same flag.
"otherTags": [ | ||
"rogue-racket" | ||
"rogue-class-archetype" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead, let's make two tags. One for racket and one that's just class-archetype
then we can restrict the class archetype choices for dedications.
"filter": [ | ||
{ | ||
"or": [ | ||
"item:tag:sorcerer-bloodline", | ||
"item:tag:sorcerer-class-archetype" | ||
] | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would make this filter:
{
"or": [
{
"and": [
"class:sorcerer",
"item:tag:sorcerer-bloodline"
]
},
{
"and": [
"item:tag:sorcerer-bloodline",
{
"not": "item:tag:class-archetype"
}
]
}
]
}
I think this should work, anyways.
Good catch on the multiclass stuff. System's getting too complicated 😓 |
While working on Flexible Spellcasting, I noticed that the choice sets for cleric doctrines and arcane schools allow you to pick class archetypes on the second round of choices.
I added
x-class-archetypes
tags to the features and updated the choice sets for subclasses to pick up on these. I updated Elemental Magic to use these tags as well.The subclass choice sets were also updated to account for whether or not it's the actual class or a dedication triggering the choice set to filter out Class Archetypes.
Let me know which parts of this PR we can keep and which ones to put on hold or scrap.
Thanks