Get more memory on ESXi before loading target #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 44.81% 44.90% +0.08%
==========================================
Files 26 26
Lines 3541 3543 +2
==========================================
+ Hits 1587 1591 +4
+ Misses 1954 1952 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Miauwkeru
requested changes
Oct 13, 2025
| else: | ||
| with context_mgr: | ||
| for target in Target.open_all(target_paths): | ||
| target_name = "Unknown" # overwrite previous target name |
Contributor
There was a problem hiding this comment.
I think this line can be removed no?
Contributor
There was a problem hiding this comment.
nvm, it is there so we do not reuse the previous target_name in case target.name fails
Miauwkeru
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.