Skip to content

Fix collection of $Secure:$SII #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
respondersGY wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix collection of $Secure:$SII #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b1202f
Fix collection of `$Secure:$SII`
respondersGY Jan 8, 2026
b25670c
Remove comment
respondersGY Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion acquire/acquire.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,11 +366,14 @@ def _run(cls, target: Target, cli_args: argparse.Namespace, collector: Collector
filenames = [
"$MFT",
"$Boot",
"$Secure:$SII",
"$Secure:$SDS",
"$LogFile",
]

sii_fh = fs.ntfs.mft.get("$Secure").index("$SII")._index_stream
Copy link
Contributor

@Miauwkeru Miauwkeru Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing it like this, wouldn't the following work too?

sii_fh = fs.ntfs.mft.get("$Secure").open("$SII", attr_type=...)

Requires less knowledge about the internals of the internal ntfs structure.


collector.output.write(fsutil.join(main_mountpoint, "$Secure:$SII"), sii_fh)
Copy link
Contributor

@Miauwkeru Miauwkeru Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be better to use collector.write_bytes assuming the stream isn't that large. Otherwise, maybe add a collector.write that writes the file header to it. E.g. something like this:

class Collector:
    ...
    def write(self, destination_path: str, fh: BinaryIO) -> None:
        self.output.write(destination_path, fh)
        self.report.add_file_collected(self.bound_module_name, destination_path)

Then we can at least keep track that the file was collected. Besides that, the destination path would need to be joined with collector.base to be placed in /fs/ properly.


for filename in filenames:
if main_mountpoint is not None:
path = fsutil.join(main_mountpoint, filename)
Expand Down