Skip to content

Conversation

@qmadev
Copy link
Contributor

@qmadev qmadev commented Jan 16, 2026

fixes #282

Schamper
Schamper previously approved these changes Jan 16, 2026
@Schamper
Copy link
Member

Can you update the unit test?

@qmadev
Copy link
Contributor Author

qmadev commented Jan 16, 2026

This should work

@qmadev qmadev requested a review from Schamper January 16, 2026 16:00
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the linter.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.92%. Comparing base (c109fe4) to head (37806a1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   44.92%   44.92%           
=======================================
  Files          26       26           
  Lines        3559     3559           
=======================================
  Hits         1599     1599           
  Misses       1960     1960           
Flag Coverage Δ
unittests 44.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qmadev
Copy link
Contributor Author

qmadev commented Jan 16, 2026

Done!

@qmadev qmadev requested a review from Schamper January 16, 2026 17:01
@Schamper Schamper merged commit a042049 into fox-it:main Jan 16, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESXi Child Collection not Working

2 participants