Update pyproject.toml license settings and minimum python version #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Miauwkeru
commented
Sep 19, 2025
Miauwkeru
commented
- Change the minimum python version to 3.10
- Update deprecated license settings
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 92.98% 93.01% +0.03%
==========================================
Files 21 21
Lines 2437 2435 -2
==========================================
- Hits 2266 2265 -1
+ Misses 171 170 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Schamper
requested changes
Sep 20, 2025
pyproject.toml
Outdated
| requires-python = "~=3.9" | ||
| license.text = "Apache License 2.0" | ||
| requires-python = ">=3.10" | ||
| license = "AGPL-3.0-or-later" |
Miauwkeru
force-pushed
the
update-pyproject-toml-file
branch
from
24bce5c to
67dc222
Compare
Miauwkeru
force-pushed
the
update-pyproject-toml-file
branch
from
059c09f to
d14c986
Compare
Schamper
requested changes
Sep 23, 2025
Member
Schamper
left a comment
Schamper
left a comment
There was a problem hiding this comment.
Update required ruff version.
Miauwkeru
force-pushed
the
update-pyproject-toml-file
branch
from
d14c986 to
6d24f97
Compare
Schamper
requested changes
Sep 24, 2025
Member
Schamper
left a comment
Schamper
left a comment
There was a problem hiding this comment.
dissect/cstruct/types/base.py
63: # Python 3.9 compat thing for bound type vars
Schamper
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.