Skip to content

Conversation

@twiggler
Copy link
Contributor

@twiggler twiggler commented Mar 13, 2025

Closes #8

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.56%. Comparing base (a37a8d2) to head (edd2a02).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/jffs/jffs2.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   88.09%   88.56%   +0.46%     
==========================================
  Files           4        4              
  Lines         252      271      +19     
==========================================
+ Hits          222      240      +18     
- Misses         30       31       +1     
Flag Coverage Δ
unittests 88.56% <94.73%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

continue

last_version = versions[-1]
if last_version.type == c_jffs2.DT_DIR:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that this code will massively benefit from fox-it/dissect.cstruct#114

@twiggler twiggler merged commit 3369100 into main Mar 31, 2025
22 checks passed
@twiggler twiggler deleted the jffs2-nlink branch March 31, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement calculation of nlink

3 participants