Skip to content

Conversation

@Schamper
Copy link
Member

@Schamper Schamper commented Nov 1, 2024

No description provided.

@codecov
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (21c1617) to head (402b723).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/jffs/jffs2.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files           4        4           
  Lines         249      249           
=======================================
  Hits          221      221           
  Misses         28       28           
Flag Coverage Δ
unittests 88.75% <88.88%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Horofic
Horofic previously approved these changes Nov 1, 2024
@Schamper
Copy link
Member Author

Schamper commented Nov 1, 2024

Failing tests are due to recent dissect.cstruct changes

@Schamper
Copy link
Member Author

Schamper commented Nov 1, 2024

@JSCU-CNI due to new behaviour in cstruct with how we deal with None values, the method used here for lost+found detection no longer worked. Let me know if you find my fix appropriate: e4a4fc1

@Schamper Schamper merged commit f93add9 into main Nov 25, 2024
20 checks passed
@Schamper Schamper deleted the std-exc branch November 25, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants