-
Notifications
You must be signed in to change notification settings - Fork 75
Skip nested objects of Velociraptor records #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't use Velociraptor so I can't measure the impact of this. Is there a lot of valuable metadata lost now? What's the recommended workflow to process that? Maybe make a note at least in the docstring. |
|
From my experience the additional metadata does not contain useful data for most cases. For these edge cases the argument The workflow depends on the search platform that is used. I use Elasticsearch therefore I don't want to deal with nested dynamic objects. |
|
@Schamper can you review the PR? |
If you ask nicely. |
|
@Schamper Can you please review the changes? |
…sect.target into fix/dissect_velo_plugin
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1480 +/- ##
==========================================
- Coverage 80.75% 80.74% -0.02%
==========================================
Files 394 394
Lines 34644 34648 +4
==========================================
- Hits 27977 27976 -1
- Misses 6667 6672 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
The objects contain additional metadata that is not necessary to output as records. In addition, some of the dynamic (nested) objects result in conflicts with other plugins, which can't be determined beforehand depending on which artefacts are collected.