Add tests data related to containers (EWF, VDI, VHD, VHDX and VMDK) #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
requested changes
Jan 14, 2026
Contributor
Author
|
It look like their is more untested container format, I will add test for them to in this PR (or in dedicated PR, as you wish). |
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Member
This PR is fine, just rename the PR title. |
william-billaud
changed the title
Schamper
requested changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests related to multiple containers format. I do not have any mac to generate tests data for mac related containers format.
Add ~1.5mo of git lfs data.
For each test, I have tried to cover most path/functions available from the container (seek, read etc...)
Bump dissect.evidence dev version.
Related to fox-it/dissect.evidence#47