Fix ESXi configstore call in OS create method

[JSCU-CNI]

Since _configstore is no longer populated in the ESXiPlugin, we have to update the reference to the config store in the create method.

The check_compatible method of ConfigStorePlugin is also updated to not use target.os since that would cause recursion.

[Schamper]

Is it possible to check this in a unit test?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.73%. Comparing base (6602b9a) to head (3bfe6bd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
+ Coverage   80.45%   80.73%   +0.28%     
==========================================
  Files         393      393              
  Lines       34544    34542       -2     
==========================================
+ Hits        27792    27888      +96     
+ Misses       6752     6654      -98     

Flag	Coverage Δ
unittests	80.73% <100.00%> (+0.28%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[codspeed-hq]

Merging this PR will not alter performance

✅ 9 untouched benchmarks

---

_{Comparing JSCU-CNI:fix-esxi-configstore-call (3bfe6bd) with main (6602b9a)}

[JSCU-CNI]

@william-billaud Could you share the esx.conf of your example ESXi 7 instance from #1385 for a unit test here?

[william-billaud]

I will take a look tomorrow.

Maybe tech supports files from https://github.com/fox-it/dissect.target/pull/1492/files would fit your need? (esx8)

[JSCU-CNI]

@william-billaud That would definitely be helpful for the test coverage of ESXi functionality. Perhaps we can add that in a separate PR.

@Schamper I've added a small test in c8a2a8e for the meantime.