-
Notifications
You must be signed in to change notification settings - Fork 75
Improve ESXiPlugin support for recent version #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| @export(record=[ESXiUserRecord, UnixUserRecord]) | ||
| def users(self) -> Iterator[ESXiUserRecord | UnixUserRecord]: | ||
| if self.version and self.version[0] < "7": | ||
| yield from super().users(sessions=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just extract the information from the UnixUserRecord and put it in a new ESXiUserRecord so that we only have that as return type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, after further analysis, /etc/passwd is still present in ESXi7+, just not collected by vmsupport/available from raw disk (probably located in local.tgz.ve). Thus I will merge both entries if available.
Fix user plugins and test
Enhance ESXiOs plugin, especially for non disk collection.
local.tgz.ve: Warning was issued even if decryption worked properly.Other changes
Note
Test on raw disk
hostname,os,domain,version,ips
users (/etc/passwd is not found)