Skip to content

Conversation

@Schamper
Copy link
Member

@Schamper Schamper commented Jul 2, 2025

Looks like #31 may not work out (or at least needs a lot more investigation), but we can take some of the small stream improvements from that branch and put them in main. Mostly stylistic things such as improved docstrings and a simplified RelativeStream/RangeStream.

@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (213256e) to head (f70351e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/util/stream.py 0.00% 39 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #88   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         22      22           
  Lines       1367    1364    -3     
=====================================
+ Misses      1367    1364    -3     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 2, 2025

CodSpeed Performance Report

Merging #88 will not alter performance

Comparing small-stream-improvements (f70351e) with main (213256e)

Summary

✅ 13 untouched

@Schamper Schamper force-pushed the small-stream-improvements branch from 68dd4bb to 633772b Compare August 13, 2025 13:59
@EinatFox EinatFox linked an issue Sep 10, 2025 that may be closed by this pull request
@Schamper Schamper merged commit 9418f46 into main Sep 22, 2025
33 checks passed
@Schamper Schamper deleted the small-stream-improvements branch September 22, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small stream improvements

3 participants