Add assertions for explicit path comparison #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 83.92% 83.92%
=======================================
Files 34 34
Lines 3466 3466
=======================================
Hits 2909 2909
Misses 557 557
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
changed the title
Schamper
approved these changes
Oct 8, 2024
Schamper
requested changes
Oct 9, 2024
tests/test_fieldtypes.py
Outdated
| @@ -689,7 +690,9 @@ def test_path() -> None: | |||
| ), | |||
| ], | |||
| ) | |||
| def test_path_multiple_parts(path_parts, expected_instance) -> None: | |||
| def test_path_multiple_parts( | |||
| path_parts: Tuple[str | pathlib.PurePath, ...], expected_instance: Type[pathlib.PurePath] | |||
There was a problem hiding this comment.
Suggested change
| path_parts: Tuple[str | pathlib.PurePath, ...], expected_instance: Type[pathlib.PurePath] | |
| path_parts: Tuple[str | pathlib.PurePath, ...], expected_instance: type[pathlib.PurePath] |
This is legal these days (unless it's another thing not allowed by 3.8, in which case ignore this comment).
There was a problem hiding this comment.
I thought this got introduced in python 3.9 but the python compatibility test passes with type instead of Type.
In any case, 3.8 is EOL now https://discuss.python.org/t/python-3-8-is-now-officially-eol/66983
tests/test_fieldtypes.py
Outdated
| @@ -1153,7 +1160,7 @@ def test_command_failed() -> None: | |||
| fieldtypes.path, | |||
| ], | |||
| ) | |||
| def test_empty_path(path_cls) -> None: | |||
| def test_empty_path(path_cls: Type[pathlib.PurePath]) -> None: | |||
There was a problem hiding this comment.
Suggested change
| def test_empty_path(path_cls: Type[pathlib.PurePath]) -> None: | |
| def test_empty_path(path_cls: type[pathlib.PurePath]) -> None: |
Schamper
previously approved these changes
Oct 9, 2024
pyrco
requested changes
Oct 10, 2024
tests/test_fieldtypes.py
Outdated
| @@ -688,7 +690,9 @@ def test_path(): | |||
| ), | |||
| ], | |||
| ) | |||
| def test_path_multiple_parts(path_parts, expected_instance): | |||
| def test_path_multiple_parts( | |||
| path_parts: Tuple[str | pathlib.PurePath, ...], expected_instance: type[pathlib.PurePath] | |||
There was a problem hiding this comment.
Suggested change
| path_parts: Tuple[str | pathlib.PurePath, ...], expected_instance: type[pathlib.PurePath] | |
| path_parts: tuple[str | pathlib.PurePath, ...], expected_instance: type[pathlib.PurePath] |
This already worked with no changes because path::__eq__ is delegating to pathlib::__eq__. Nevertheless, let's prevent regressions.
twiggler
force-pushed
the
path-comparison
branch
from
d62a013
to
84f087f
Compare
pyrco
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, this issue was about implementing explicit path comparisons such as
path == posix_path(/usr/local/ls").As it turns out, this behavior is already supported by flow.record
path, because it delegates to the superclass methodpathlib::__eq__.Added some assertions (actually I started with these and found out it already works as intended) to prevent regressions.
Bonus: improve typing of tests.
Closes #146