Improve elastic adapter exception handling #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves exception handling of the Elastic adapter. Currently when an Elasticsearch endpoint is unreachable
rdump
will stay stuck in a thread. We have added athreading.excepthook
to make surerdump
exists with a non-zero status code. Let us know if you prefer a different method of propagating exceptions in rdump. Currently the stdout is a bit noisey, but at least rdump is no longer stuck.Steps to reproduce: