feat: PredictiveSynchronizer #533
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertok
commented
Nov 19, 2025
elementbound
reviewed
Dec 1, 2025
| func _run_prediction_tick(tick: int) -> void: | ||
| for node in _nodes: | ||
| var is_fresh := _freshness_store.is_fresh(node, tick) | ||
| node._predict_tick(NetworkTime.ticktime, tick, is_fresh) |
Contributor
There was a problem hiding this comment.
I'm considering using _rollback_tick() here too.
pros: consistency, code doesn't need to be touched to go from RBS to PredictiveSynchronizer
cons: might be confusing? + might not work well with mixed / nested setups
Thoughts?
Contributor
Author
There was a problem hiding this comment.
I'd much prefer it be called _rollback_tick also but it does leave the door wide open to unintended side effects.
Can I guard against a double call by checking is_simulated maybe?
elementbound
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Closes #374