Skip to content

fix: TickInterpolator records state after RollbackSynchronizer displa… #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-ruecker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: TickInterpolator records state after RollbackSynchronizer displa… #539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions addons/netfox/tick-interpolator.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,20 @@ func _get_configuration_warnings() -> PackedStringArray:

func _connect_signals() -> void:
NetworkTime.before_tick_loop.connect(_before_tick_loop)
NetworkTime.after_tick_loop.connect(_after_tick_loop)
# Connect to after_loop instead of after_tick_loop to ensure state is recorded
# AFTER RollbackSynchronizer applies display state, fixing jittery remote
# player interpolation on the host.
if NetworkRollback.enabled:
NetworkRollback.after_loop.connect(_after_tick_loop)
else:
NetworkTime.after_tick_loop.connect(_after_tick_loop)

func _disconnect_signals() -> void:
NetworkTime.before_tick_loop.disconnect(_before_tick_loop)
NetworkTime.after_tick_loop.disconnect(_after_tick_loop)
if NetworkRollback.enabled:
NetworkRollback.after_loop.disconnect(_after_tick_loop)
else:
NetworkTime.after_tick_loop.disconnect(_after_tick_loop)

func _enter_tree() -> void:
if Engine.is_editor_hint():
Expand Down