Conversation
camh-
force-pushed
the
hermitise
branch
3 times, most recently
from
165c09a to
2d5c913
Compare
juliaogris
previously approved these changes
Jan 30, 2025
Member
juliaogris
left a comment
juliaogris
left a comment
There was a problem hiding this comment.
sorry this took so long! 💚
Hermitise this repository as the version of golangci-lint used is not
compatible with more recent Go releases so we will either need to pin to
an older version of Go or upgrade golangci-lint. The former is tricky to
do simply, and the latter is painful with the churn in golangci-lint.
The alternative is to use hermit and pin the versions currently
required. This is what is done here:
hermit init --no-git
hermit install go-1.13.5
hermit install golangci-lint-1.37.0
Remove the custom version login for golangci-lint from the Makefile, and
add the hermit auto-activation. Note that the only 1.13 version of Go in
hermit is 1.13.5, while the latest point release is 1.13.15. I chose
1.13 as that is what is in the `go.mod` file.
Subsequent commits will bump these versions and adjust the code to work
with newer golangci-lint errors.
Update GitHub CI to rely on hermit for installing the right versions
instead of using specific actions. Also run on all PRs, not just those
to be merged to master. This allows CI to run for stacked PRs.
Add `/.hermit/` to `.gitignore` - this is hermit's "state" directory for
certain hermit packages and should never be committed.
juliaogris
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hermitise this repository as the version of golangci-lint used is not
compatible with more recent Go releases so we will either need to pin to
an older version of Go or upgrade golangci-lint. The former is tricky to
do simply, and the latter is painful with the churn in golangci-lint.
The alternative is to use hermit and pin the versions currently
required. This is what is done here:
Remove the custom version login for golangci-lint from the Makefile, and
add the hermit auto-activation. Note that the only 1.13 version of Go in
hermit is 1.13.5, while the latest point release is 1.13.15. I chose
1.13 as that is what is in the
go.modfile.Subsequent commits will bump these versions and adjust the code to work
with newer golangci-lint errors.
Update GitHub CI to rely on hermit for installing the right versions
instead of using specific actions. Also run on all PRs, not just those
to be merged to master. This allows CI to run for stacked PRs.
Add
/.hermit/to.gitignore- this is hermit's "state" directory forcertain hermit packages and should never be committed.