Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: split large io by flush_io_size in the new model #874

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Mar 6, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. To optimize inode lock hold duration. #873

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #873

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added the perf Performance optimization label Mar 6, 2025
@MrCroxx MrCroxx added this to the v0.15 milestone Mar 6, 2025
@MrCroxx MrCroxx self-assigned this Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 72.60274% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-storage/src/store.rs 42.85% 12 Missing ⚠️
foyer-storage/src/large/flusher.rs 87.17% 5 Missing ⚠️
foyer-storage/src/large/generic.rs 76.92% 3 Missing ⚠️
Files with missing lines Coverage Δ
foyer-storage/src/large/generic.rs 90.60% <76.92%> (-0.45%) ⬇️
foyer-storage/src/large/flusher.rs 85.81% <87.17%> (+0.02%) ⬆️
foyer-storage/src/store.rs 84.61% <42.85%> (-2.09%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MrCroxx added 3 commits March 6, 2025 17:21
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance optimization
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

perf: unexpectedly high read latency on slow disk with the new io model
1 participant