Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspaces): preserve d.(c|m)ts directory structure #10

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

jacob-alford
Copy link
Collaborator

I ran into an issue with TypeScript in a workspace / composite TSconfig settting where TS needed the root-directory specified. This meant that all emitted declaration files were emitted with a preserved structure, i.e. inside of the source directory. This cleaned up the output quite substantially, where dist files contain plain javascript, and dts and ts files from src are colocated in the dist/src directory.

Note for library authors:

This will not produce any breaking changes with your library unless you're incidentally doing some post-processing after the fact, but note the caveat below.

If you publish from dist upgrading to 0.5.0 there is nothing you need to do. If you publish from . you will need to adjust your type exports to point to ./dist/src/... instead.

@jacob-alford jacob-alford merged commit 2116d9f into main Aug 20, 2024
3 checks passed
@jacob-alford jacob-alford deleted the ja/fix-workspaces branch August 20, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant