Preserve library structure #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the way build-tools treats the root and source directories. Now, build-tools will preserve the structure of your library. This means that files built in the
srcdirectory will output indist/src. And files in the root directory will output indist. This is to allow multi-entrypoint libraries to opt-in to node10 support by simply moving their entrypoints into the root directory.The only breaking change for everyone is that the "entrypoint" value for
type: "single"in build-mode now no longer points tosrc. So if you are keeping your entrypoint insrcyou must update this value.If you are not publishing from dist, you must also update your exports / main / module / types to reflect the new structure.
If you follow the above instructions, you can avoid pushing a breaking change to your library.