Feat: add .d.ts, .d.cts, and .d.mts generation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob-alford
commented
Feb 8, 2024
src/TypesService.ts
Outdated
| node.modifiers, | ||
| node.importClause, | ||
| ts.factory.createStringLiteral( | ||
| './' + path.join(dirname, remapExtension(fileNameWithExtension)), |
There was a problem hiding this comment.
I might need to add a ../ instead here if importPath starts with ../
jacob-alford
commented
Feb 8, 2024
src/constants.ts
Outdated
|
|
||
| export const DMTS_PATH = './mts' | ||
|
|
||
| export const DCTS_PATH = './cts' |
There was a problem hiding this comment.
Need to delete this file
jacob-alford
commented
Feb 8, 2024
tsconfig.json
Outdated
| @@ -1,17 +1,21 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "module": "NodeNext", | |||
| "module": "Node16", | |||
| "target": "ESNext", | |||
| "moduleResolution": "NodeNext", | |||
There was a problem hiding this comment.
Need to make this Node16
jacob-alford
commented
Feb 8, 2024
tsconfig.json
Outdated
Comment on lines
16
to
18
| "src/BuildService.ts", | ||
| "src/ConfigService.ts", | ||
| "src/ExportsService.ts" |
There was a problem hiding this comment.
Why did I add these?
jacob-alford
force-pushed
the
ja/new-config
branch
from
c1a07be to
c05d427
Compare
jacob-alford
commented
Feb 12, 2024
| }, | ||
| }, | ||
| './foo.cjs', | ||
| './foo.js', |
There was a problem hiding this comment.
Also fix these tests (and add tests to lint-staged / CI)
src/TypesService.ts
Outdated
| } | ||
|
|
||
| const rewriteMapFileExtension: Endomorphism<string> = fileText => | ||
| fileText.replace(/\.d\.ts/g, '.d.mts') |
There was a problem hiding this comment.
Need a cts version of this
| case 'module': | ||
| return { '.d.ts': emitDts } | ||
| case 'commonjs': | ||
| return { '.d.cts': emitDcts } |
There was a problem hiding this comment.
Not sure about these...
| case 'module': | ||
| return { '.d.mts': emitDmts } | ||
| case 'commonjs': | ||
| return { '.d.ts': emitDts } |
jacob-alford
force-pushed
the
ja/new-config
branch
from
87a0ea1 to
e0abf53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.