Skip to content

Comments

feat: add router extension and export axum#8

Merged
psibi merged 4 commits intomainfrom
rest-api-extend
Feb 16, 2026
Merged

feat: add router extension and export axum#8
psibi merged 4 commits intomainfrom
rest-api-extend

Conversation

@psibi
Copy link
Member

@psibi psibi commented Feb 16, 2026

Expose the Axum crate and allow router extensions through the WatcherAppContext trait. This allows developers to define custom API endpoints and state while maintaining version compatibility with the underlying web server.

Simplify internal configuration logic by removing the defaults module. Define default values for retries and delays directly within the WatcherConfig structure and update the example to demonstrate custom routing.

This change introduces a global 3-second timeout to the REST API server
using tower-http's TimeoutLayer. This ensures that hanging requests are
terminated early with a 408 Request Timeout status code.

Additionally, the documentation for TaskConfig has been expanded to
provide clearer explanations of task execution delays, retries, and
how the out-of-date setting affects task monitoring and timeouts.
Expose the Axum crate and allow router extensions through the
WatcherAppContext trait. This allows developers to define custom API
endpoints and state while maintaining version compatibility with
the underlying web server.

Simplify internal configuration logic by removing the defaults
module. Define default values for retries and delays directly
within the WatcherConfig structure and update the example to
demonstrate custom routing.
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7acf9174d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@psibi psibi requested a review from snoyberg February 16, 2026 09:07
@psibi psibi merged commit 61c077c into main Feb 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants