Conversation
This change introduces a global 3-second timeout to the REST API server using tower-http's TimeoutLayer. This ensures that hanging requests are terminated early with a 408 Request Timeout status code. Additionally, the documentation for TaskConfig has been expanded to provide clearer explanations of task execution delays, retries, and how the out-of-date setting affects task monitoring and timeouts.
Expose the Axum crate and allow router extensions through the WatcherAppContext trait. This allows developers to define custom API endpoints and state while maintaining version compatibility with the underlying web server. Simplify internal configuration logic by removing the defaults module. Define default values for retries and delays directly within the WatcherConfig structure and update the example to demonstrate custom routing.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7acf9174d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
snoyberg
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the Axum crate and allow router extensions through the WatcherAppContext trait. This allows developers to define custom API endpoints and state while maintaining version compatibility with the underlying web server.
Simplify internal configuration logic by removing the defaults module. Define default values for retries and delays directly within the WatcherConfig structure and update the example to demonstrate custom routing.