Conversation
|
|
Connected to Huly®: DAPPK-147 |
| contractAddress, | ||
| tokenId, | ||
| }: PropsWithChildren<NFTCardType>) => { | ||
| const { |
There was a problem hiding this comment.
in this case it's fine while generally we might prefer nanostore over context provider
https://github.com/nanostores/nanostores
| @@ -0,0 +1,74 @@ | |||
| export interface NFTResponse { | |||
There was a problem hiding this comment.
we can put types into the api.ts
| className="text-right font-semibold text-black" | ||
| > | ||
| {nftData?.owner?.ens_domain_name ?? | ||
| formatAddress(nftData?.owner?.hash ?? "")} |
There was a problem hiding this comment.
lets use existing components / utils
we do hv
| contractAddress: string; | ||
| } | ||
|
|
||
| function ERC721CardStories({ |
There was a problem hiding this comment.
can we create 2 stories for 2 separate smart vs dumb components
(similar to TransactionTable vs TransactionTableWithDetails
end goal is we don't dictate the data source
| export function NFTMedia() { | ||
| const { nftData } = useNFT(); | ||
|
|
||
| const imageUrl = nftData?.image_url; |
There was a problem hiding this comment.
@iyansr do you hv example data for blockscout nft url?
many NFT provide ipfs hash so we need explicit ipfs gateway control on the image to be shown
(reference getIpfsGatewayUrl)
2 participants
Preview