Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create organisation does not reflect app-wide #2257

Merged
merged 5 commits into from
Mar 5, 2025
Merged

fix: create organisation does not reflect app-wide #2257

merged 5 commits into from
Mar 5, 2025

Conversation

orimdominic
Copy link
Collaborator

@orimdominic orimdominic commented Mar 5, 2025 •
edited
Loading

Bug

When an organisation is created, other components are not updated.

Fix

This PR uses React's Context API (for now) to propagate the update

Points to note

  • Plans are in order to use a state management library instead of React's Context API because React's Context API is not performant, rendering-wise.
  • This PR also changes the way that layout routes are set up, choosing to use the route.tsx pattern rather than the _layout folder pattern

@orimdominic orimdominic merged commit ca4c7a0 into dashboard-react Mar 5, 2025
2 of 4 checks passed
@orimdominic orimdominic deleted the fix/create-organisation branch March 5, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@orimdominic