fix(models): make Position.name optional to handle null API responses #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bloom Growth API can return null for Position.name field, causing Pydantic validation errors in UserOperations methods like positions(), details(include_positions=True), and details(all=True). - Changed Position.name from required str to optional str | None - Added tests for positions() with null names - Added tests for details(all=True) with null position names 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nullforPosition.namefieldPosition.nameoptional (str | None = None) in the modelsChanges
src/bloomy/models.py: ChangedPosition.namefrom requiredstrto optionalstr | Nonetests/test_users.py: Added two new tests:test_positions_with_null_name- Testspositions()method with null namestest_details_with_positions_null_name- Testsdetails(all=True)with null position namesContext
The
UserOperationsmethodspositions(),details(include_positions=True), anddetails(all=True)were failing with Pydantic validation errors because the API returnsnullforPosition.namebut the model had it defined as a required field.Test plan
positions()anddetails(all=True)handle null names correctly🤖 Generated with Claude Code