Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the support of writing async __new__ #11

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

francis-clairicia
Copy link
Owner

Why remove async def __new__?

When I wrote the first version of this library, it was mostly to prove that something like this was possible. But in practical use:

  1. There is no need to perform asynchronous operations on object allocation.
  2. This can lead to confusion with other base classes.
  3. It is hard to maintain such a feature that involves the creation of the object itself.

@francis-clairicia francis-clairicia added enhancement New feature or request breaking-changes Backward incompatible update labels Dec 27, 2023
@francis-clairicia francis-clairicia self-assigned this Dec 27, 2023
@francis-clairicia francis-clairicia force-pushed the feature/remove-async-dunder-new branch 2 times, most recently from 08533ea to eaf4e95 Compare December 27, 2023 12:10
@francis-clairicia francis-clairicia merged commit 6e19718 into main Dec 27, 2023
13 checks passed
@francis-clairicia francis-clairicia deleted the feature/remove-async-dunder-new branch December 27, 2023 12:17
@francis-clairicia francis-clairicia changed the title Removed the support of writing async __new__ Removed the support of writing async __new__ Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes Backward incompatible update enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant