fixed tag exclusion bug

franciskafieh · Nov 13, 2024 · 08799aa · 08799aa
1 parent 1f02af9
commit 08799aa
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/src/logic/file_tracking/fileMatchesCriteria.ts b/src/logic/file_tracking/fileMatchesCriteria.ts
@@ -5,7 +5,7 @@ import { Settings } from "../../interfaces/Settings";
 export default function fileMatchesCriteria(
 	file: File,
 	allTags: string[] | null,
-	settings: Settings,
+	settings: Settings
 ) {
 	// check tags
 	if (allTags) {

diff --git a/src/logic/log_note/getFill.ts b/src/logic/log_note/getFill.ts
@@ -11,6 +11,7 @@ export function getFill(context: Context) {
 	const modified = [];
 	const deleted = [];
 	const trackedFiles = settings.trackedFiles;
+
 	for (const trackedFile of trackedFiles) {
 		if (!trackedFile.matchesCriteria || !trackedFile.path) {
 			continue;

diff --git a/src/obsidian/listeners/onMetadataCacheChanged.ts b/src/obsidian/listeners/onMetadataCacheChanged.ts
@@ -46,7 +46,7 @@ const onMetadataCacheChanged = serialize(
 
 		const matchesCriteria = fileMatchesCriteria(
 			file,
-			getAllTags(cache),
+			getAllTags(cache)?.map((tag) => tag.substring(1)) || null,
 			settings
 		);
 

diff --git a/tests/logic/file_tracking/fileMatchesCriteria.test.ts b/tests/logic/file_tracking/fileMatchesCriteria.test.ts
@@ -45,6 +45,16 @@ describe("fileMatchesCriteria should correctly match ignored name text", () => {
 			)
 		).toBe(false);
 	});
+
+	it("should fail on name if matching one, combined with other text", () => {
+		expect(
+			fileMatchesCriteria(
+				getSingleFileWithPath("a-abcaa.md"),
+				[""],
+				new TestSettingsBuilder().setIgnoredNameContains("abc").build()
+			)
+		).toBe(false);
+	});
 });
 
 describe("fileMatchesCriteria should correctly match ignored folder/path", () => {