Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to add timezone support. #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benmurden
Copy link
Contributor

In order to avoid timezone support warnings, change default values for
metric items and gauges to timezone aware equivalents from
django.utils.timezone.

This requires some changes to move_to_mixpanel command so timestamps can
be calculated correctly. To support more platforms, changed the use of
strftime('%s') to a more compatible implementation that closely follows
the Python 3 implementation of timestamp().

Added timedelta_total_seconds() to allow continued support for Python
2.6.

Added tests for timestamp utility functions.

In order to avoid timezone support warnings, change default values for
metric items and gauges to timezone aware equivalents from
django.utils.timezone.

This requires some changes to move_to_mixpanel command so timestamps can
be calculated correctly. To support more platforms, changed the use of
strftime('%s') to a more compatible implementation that closely follows
the Python 3 implementation of timestamp().

Added timedelta_total_seconds() to allow continued support for Python
2.6.

Added tests for timestamp utility functions.
@benmurden
Copy link
Contributor Author

Seems to be breaking support for Django 1.3, where timezone doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant