Merge pull request #221 from RitvikSardana/develop-ritvik-report-fix

fix: edge case where year_start_date is not present in academic year
frappe · Mar 13, 2024 · 3522410 · 3522410
2 parents 032054c + e1b3769
commit 3522410
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/education/education/api.py b/education/education/api.py
@@ -618,9 +618,6 @@ def apply_leave_based_on_course_schedule(leave_data, program_name):
 		},
 		order_by="schedule_date asc",
 	)
-	print("-------------------")
-	print(course_schedule_in_leave_period)
-	print("-------------------")
 
 	if frappe.db.exists("Student Attendance", {"course_schedule": "EDU-CSH-2024-00003"}):
 		pass

diff --git a/education/education/doctype/student_leave_application/student_leave_application.py b/education/education/doctype/student_leave_application/student_leave_application.py
@@ -71,7 +71,6 @@ def update_attendance(self):
 			},
 			fields=["name"],
 		)
-		print("leave_classes", leave_classes)
 
 		holiday_list = get_holiday_list()
 

diff --git a/...ion/education/report/student_monthly_attendance_sheet/student_monthly_attendance_sheet.py b/...ion/education/report/student_monthly_attendance_sheet/student_monthly_attendance_sheet.py
@@ -158,7 +158,7 @@ def mark_holidays(att_map, from_date, to_date, students_list):
 def get_year_list():
 	all_academic_years = frappe.db.get_list("Academic Year", pluck="year_start_date")
 
-	year_list = [date.year for date in all_academic_years]
+	year_list = [date.year for date in all_academic_years if date]
 	year_list = list(set(year_list))
 	year_list.sort()