Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edge case where year_start_date is not present in academic year #221

Merged
merged 2 commits into from
Mar 13, 2024
Merged

fix: edge case where year_start_date is not present in academic year #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f25db6
fix: edge case where no year_start_date is not present in academic year
RitvikSardana Mar 13, 2024
e1b3769
chore: remove print statement
RitvikSardana Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions education/education/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,9 +618,6 @@ def apply_leave_based_on_course_schedule(leave_data, program_name):
},
order_by="schedule_date asc",
)
print("-------------------")
print(course_schedule_in_leave_period)
print("-------------------")

if frappe.db.exists("Student Attendance", {"course_schedule": "EDU-CSH-2024-00003"}):
pass
Expand Down
1 change: 0 additions & 1 deletion education/education/doctype/student_leave_application/student_leave_application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ def update_attendance(self):
},
fields=["name"],
)
print("leave_classes", leave_classes)

holiday_list = get_holiday_list()

Expand Down
2 changes: 1 addition & 1 deletion ...ion/education/report/student_monthly_attendance_sheet/student_monthly_attendance_sheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def mark_holidays(att_map, from_date, to_date, students_list):
def get_year_list():
all_academic_years = frappe.db.get_list("Academic Year", pluck="year_start_date")

year_list = [date.year for date in all_academic_years]
year_list = [date.year for date in all_academic_years if date]
year_list = list(set(year_list))
year_list.sort()

Expand Down
Loading