fix: stock_value_change for legacy serial nos (#41825)

frappe · Jun 7, 2024 · f6a4d39 · f6a4d39
1 parent 3956354
commit f6a4d39
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/erpnext/stock/stock_ledger.py b/erpnext/stock/stock_ledger.py
@@ -837,7 +837,7 @@ def get_serialized_values(self, sle):
 				)
 
 				outgoing_value = sn_obj.get_incoming_rate()
-				stock_value_change = -1 * outgoing_value
+				stock_value_change = actual_qty * outgoing_value
 			else:
 				stock_value_change = actual_qty * sle.outgoing_rate
 
@@ -1312,6 +1312,7 @@ def update_batched_values(self, sle):
 				# future entries will correct the overall accounting as each
 				# batch individually uses moving average rates.
 				outgoing_rate = self.get_fallback_rate(sle)
+
 			stock_value_difference = outgoing_rate * actual_qty
 
 		self.wh_data.stock_value = round_off_if_near_zero(self.wh_data.stock_value + stock_value_difference)