Merge pull request #43602 from ljain112/fix-closing-balances

fix: added parentheses for correct query formation for logical OR condition
frappe · Oct 15, 2024 · fc66408 · fc66408
2 parents 4e8f3fe + c0da8f1
commit fc66408
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py
@@ -353,9 +353,10 @@ def get_balances_based_on_dimensions(
 
 		if get_opening_entries:
 			query = query.where(
-				gl_entry.posting_date.between(self.get("year_start_date"), self.posting_date)
-				| gl_entry.is_opening
-				== "Yes"
+				(  # noqa: UP034
+					(gl_entry.posting_date.between(self.get("year_start_date"), self.posting_date))
+					| (gl_entry.is_opening == "Yes")
+				)
 			)
 		else:
 			query = query.where(