fix(notification): align with https://github.com/frappe/frappe/pull/22595 #38157
Conversation
blaggacao
requested review from
rohitwaghchaure,
s-aga-r,
deepeshgarg007 and
ruthra-kumar
as code owners
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
…-comply-with-upstream
|
Upstream was merged already. 😄 |
|
This is ready to merge (before force-staled, please). |
...accounts/notification/notification_for_new_fiscal_year/notification_for_new_fiscal_year.json
Outdated
Show resolved
Hide resolved
...accounts/notification/notification_for_new_fiscal_year/notification_for_new_fiscal_year.html
Outdated
Show resolved
Hide resolved
...otification/material_request_receipt_notification/material_request_receipt_notification.html
Outdated
Show resolved
Hide resolved
|
@barredterra Nice! Thank you for the translations! 👍 |
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
blaggacao
force-pushed
the
fix/notification-comply-with-upstream
branch
from
79e7830
to
c619255
Compare
|
I think we'd be ready to merge on this? |
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
unstale |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
@Mergifyio update |
✅ Branch has been successfully updated |
Head branch was pushed to by a user without write access
|
@deepeshgarg007: @barredterra and myself had another round of review. It should be finally good now. |
Companion to frappe/frappe#22595