fix: use old serial / batch fields to make serial batch bundle #39718
Conversation
rohitwaghchaure
requested review from
deepeshgarg007,
s-aga-r and
ruthra-kumar
as code owners
rohitwaghchaure
force-pushed
the
create-bundle-using-old-fields
branch
4 times, most recently
from
ae5b432
to
381a2bc
Compare
|
Does it completely ignore SBB or creates SBB on the fly? |
It won't ignore SBB, if the user has used old fields to enter serial / batches then system will create the SBB in the backend on the submission of the respective stock transaction. Valuation and quantity calculation will be based on the SBB, while the old serial/batch fields are retained to solve UX issues . |
rohitwaghchaure
force-pushed
the
create-bundle-using-old-fields
branch
from
381a2bc
to
d361b54
Compare
rohitwaghchaure
force-pushed
the
create-bundle-using-old-fields
branch
from
d361b54
to
c1e869f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #39718 +/- ##
===========================================
+ Coverage 60.12% 60.21% +0.08%
===========================================
Files 758 758
Lines 70971 71141 +170
===========================================
+ Hits 42674 42834 +160
- Misses 28297 28307 +10
|
rohitwaghchaure
force-pushed
the
create-bundle-using-old-fields
branch
from
521323a
to
0165012
Compare
…-39718 fix: use old serial / batch fields to make serial batch bundle (backport #39718)
|
@rohitwaghchaure It would be useful to have a patch which enables this option for all existing records that are using the |
| @@ -105,6 +106,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe | |||
|
|
|||
| frappe.ui.form.on(this.frm.doctype + " Item", { | |||
| items_add: function(frm, cdt, cdn) { | |||
| debugger | |||
There was a problem hiding this comment.
@rohitwaghchaure you missed removing a debugger here ;)
There was a problem hiding this comment.
The doctor left a knife in the patient's heart :)
Stock Settings
Added "Use Serial / Batch Fields" checkbox in the Stock Settings
Added "Use Serial / Batch Fields" checkbox in the Delivery Note Item, Purchase Receipt Item, Stock Entry Detail etc.
If the user has enabled the "Use Serial / Batch Fields" checkbox in the stock settings then system keep default "Use Serial / Batch Fields" checkbox enabled in the stock transactions.
Stock Transaction (Delivery Note)
If the "Use Serial / Batch Fields" has enabled then user can use the Serial and Batch fields to make stock transactions against the Serial / Batches. On submission of the stock transaction system will auto create the Serial and Batch bundle
Disable 'Use Serial / Batch Fields'
If user wants to use the serial and batch bundle then they have to disable the checkbox "Use Serial / Batch Fields" in the line item
