Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Inventory Dimension): reduce perms for Stock User (backport #42226) #42243

Merged
merged 2 commits into from
Jul 9, 2024
Merged

fix(Inventory Dimension): reduce perms for Stock User (backport #42226) #42243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86bd20f
fix(Inventory Dimension): reduce perms for Stock User (#42226)
barredterra Jul 9, 2024
3349be1
chore: fix conflicts
rohitwaghchaure Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions erpnext/stock/doctype/inventory_dimension/inventory_dimension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@
],
"index_web_pages_for_search": 1,
"links": [],
"modified": "2023-10-05 12:52:18.705431",
"modified": "2024-07-08 08:58:50.228211",
"modified_by": "Administrator",
"module": "Stock",
"name": "Inventory Dimension",
Expand Down Expand Up @@ -221,19 +221,11 @@
"write": 1
},
{
"create": 1,
"delete": 1,
"email": 1,
"export": 1,
"print": 1,
"read": 1,
"report": 1,
"role": "Stock User",
"share": 1,
"write": 1
"role": "Stock User"
}
],
"sort_field": "modified",
"sort_order": "DESC",
"states": []
}
}
2 changes: 1 addition & 1 deletion erpnext/stock/doctype/inventory_dimension/inventory_dimension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class InventoryDimension(Document):
dimension_name: DF.Data
disabled: DF.Check
document_type: DF.Link | None
fetch_from_parent: DF.Literal
fetch_from_parent: DF.Literal[None]
istable: DF.Check
mandatory_depends_on: DF.SmallText | None
reference_document: DF.Link
Expand Down
Loading