Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Currency rates not fetched when creating mapped doc #42246

Closed

Conversation

priyanshshah2442
Copy link

@priyanshshah2442 priyanshshah2442 commented Jul 9, 2024

depends on frappe/frappe#27055 (merged)
closes #41841

Before

For eg , When a user tried to create a Sales Invoice from Sales Order currency rates were not fetched if the user changed it.

before.mov

After

after.mov

@sagarvora sagarvora marked this pull request as draft July 9, 2024 13:56
@sagarvora sagarvora changed the title fix: Currency rates not fetched fix: Currency rates not fetched when creating mapped doc Jul 10, 2024
Copy link

stale bot commented Jul 27, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jul 27, 2024
@stale stale bot closed this Aug 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currency Rate not fetched
1 participant