fix: improved the conditions for determining voucher subtypes #43273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljain112
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
github-actions
bot
added
accounts
needs-tests
ljain112
force-pushed
the
fix-voucher-types
branch
from
22aac20
to
00eee16
Compare
|
@ruthra-kumar, Should we patch this? |
ruthra-kumar
requested review from
ruthra-kumar
and removed request for
rohitwaghchaure and
deepeshgarg007
Yes. When this field was introduced, we intentionally didn't patch old data. So, while patching now, we only have to worry about rows with |
vorasmit
reviewed
Oct 7, 2024
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
Is there any blocker for this change? |
vorasmit
approved these changes
Nov 7, 2024
vorasmit
added
squash
|
LGTM. |
ruthra-kumar
approved these changes
Nov 8, 2024
This was referenced Nov 8, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Nov 8, 2024
…-43273 fix: improved the conditions for determining voucher subtypes (backport #43273)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_debit_noteCloses: #39382, #39382
Frappe Support Issue: https://support.frappe.io/app/hd-ticket/18562
backport version-15-hotfix
backport version-14-hotfix