Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change dynamic link doctype fieldtype to data #43307

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

venkat102
Copy link
Contributor

Issue:
Columns voucher_type and party_type are linked with DocType, since users won't have permission for DocType it throws an insufficient permission error
ref: 22230

Before:
Screenshot from 2024-09-20 10-57-34

After:
Screenshot from 2024-09-20 10-57-53

Backport needed: v14 & v15

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 20, 2024
@ruthra-kumar ruthra-kumar merged commit 8e7659e into frappe:develop Sep 23, 2024
14 checks passed
@ruthra-kumar ruthra-kumar self-assigned this Sep 23, 2024
@ruthra-kumar ruthra-kumar removed the request for review from deepeshgarg007 September 23, 2024 12:21
ruthra-kumar added a commit that referenced this pull request Sep 23, 2024
…-43307

fix: change dynamic link doctype fieldtype to data (backport #43307)
ruthra-kumar added a commit that referenced this pull request Sep 23, 2024
…-43307

fix: change dynamic link doctype fieldtype to data (backport #43307)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants