Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show chart tool tip in report currency #43308

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

venkat102
Copy link
Contributor

Issue: When there are multiple companies with different currencies, the report chart tooltip shows the global default currency instead of the report currency
ref: 21723

Before:
tooltip-issue

After:
tooltip-fix

Backport needed: v14 & v15

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 20, 2024
@venkat102 venkat102 marked this pull request as draft September 20, 2024 06:30
@venkat102
Copy link
Contributor Author

The related PR in frappe is frappe/frappe#27843

@ruthra-kumar ruthra-kumar removed the request for review from deepeshgarg007 September 20, 2024 07:27
@venkat102 venkat102 marked this pull request as ready for review September 20, 2024 09:14
@ruthra-kumar ruthra-kumar merged commit 8fccc70 into frappe:develop Sep 23, 2024
13 checks passed
@ruthra-kumar ruthra-kumar self-assigned this Sep 23, 2024
ruthra-kumar added a commit that referenced this pull request Sep 23, 2024
…-43308

fix: show chart tool tip in report currency (backport #43308)
ruthra-kumar added a commit that referenced this pull request Sep 23, 2024
…-43308

fix: show chart tool tip in report currency (backport #43308)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants