Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump pycountry version in ERPNext to be compatible with the frappe one #43317

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

FHenry
Copy link
Contributor

@FHenry FHenry commented Sep 21, 2024

Actual result of
bench setup requirements failed on develop branch (frappe and ERPNext)

/workspace/development/frappe-bench$ bench setup requirements
$ /workspace/development/frappe-bench/env/bin/python -m pip install --quiet --upgrade pip
Installing 4 applications...
Installing frappe
$ /workspace/development/frappe-bench/env/bin/python -m pip install --quiet --upgrade -e /workspace/development/frappe-bench/apps/frappe 

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
erpnext 16.0.0.dev0 requires pycountry~=22.3.5, but you have pycountry 24.6.1 which is incompatible.

Since frappe/frappe@81b8b84b commit (ping @barredterra) the version is 24.6.1 in frappe

May be a another fix can be to remove this dependencies in ERPNext as it is already provided by Frappe ?

@barredterra barredterra merged commit 6e34d52 into frappe:develop Sep 21, 2024
19 checks passed
@FHenry FHenry deleted the dev_remove_dependency_conflict branch September 22, 2024 00:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants