Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle missing liability account scenario in set_liability_account #43321

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: handle missing liability account scenario in set_liability_account #43321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions erpnext/accounts/doctype/payment_entry/payment_entry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,21 @@ def set_liability_account(self):
self.is_opening = "No"
return

liability_account = get_party_account(
self.party_type, self.party, self.company, include_advance=True
)[1]
accounts = get_party_account(self.party_type, self.party, self.company, include_advance=True)

liability_account = accounts[1] if len(accounts) > 1 else None
fieldname = (
ruthra-kumar marked this conversation as resolved.
Show resolved Hide resolved
"default_advance_received_account"
if self.party_type == "Customer"
else "default_advance_paid_account"
)

if not liability_account:
throw(
_("Please set default {0} in Company {1}").format(
frappe.bold(frappe.get_meta("Company").get_label(fieldname)), frappe.bold(self.company)
)
)

self.set(self.party_account_field, liability_account)

Expand Down
Loading