Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: partial return on POS invoice (backport #43253) #43342

Merged
merged 3 commits into from
Sep 23, 2024
Merged

fix: partial return on POS invoice (backport #43253) #43342

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef7d4fe
fix: partial return on POS invoice
Nihantra-Patel Sep 17, 2024
50e0f56
fix: partial return on POS invoice
Nihantra-Patel Sep 17, 2024
5ce4dae
chore: resolve conflict
ruthra-kumar Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion erpnext/accounts/doctype/pos_invoice/pos_invoice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ def validate_payment_amount(self):
if self.is_return and entry.amount > 0:
frappe.throw(_("Row #{0} (Payment Table): Amount must be negative").format(entry.idx))

if self.is_return:
if self.is_return and self.docstatus != 0:
invoice_total = self.rounded_total or self.grand_total
if total_amount_in_payments and total_amount_in_payments < invoice_total:
frappe.throw(_("Total payments amount can't be greater than {}").format(-invoice_total))
Expand Down
Loading