-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: performance optimizations for accounting reports by refactoring account closing balance and period closing voucher #43435
Merged
nabinhait
merged 11 commits into
frappe:develop
from
nabinhait:accounting-reports-performance
Oct 23, 2024
Merged
perf: performance optimizations for accounting reports by refactoring account closing balance and period closing voucher #43435
nabinhait
merged 11 commits into
frappe:develop
from
nabinhait:accounting-reports-performance
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
requested review from
deepeshgarg007,
rohitwaghchaure,
s-aga-r and
ruthra-kumar
as code owners
September 30, 2024 06:26
nabinhait
force-pushed
the
accounting-reports-performance
branch
2 times, most recently
from
October 22, 2024 14:55
b320b9d
to
daad8d4
Compare
nabinhait
force-pushed
the
accounting-reports-performance
branch
from
October 23, 2024 04:15
bc05987
to
b726ad7
Compare
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
… account closing balance and period closing voucher (#43435) * fix: Gl Entry form cleanup * fix: Added indexes in gl entry table * perf: Refactored period closing voucher to handle large volume of gle * fix: fixes as per new period start and end date fields in PCV * perf: performance optimization for accounting reports * perf: performance optimizations for account closing balance patch * fix: test cases * fix: lenter issues - direct use of sql query * fix: test cases * fix: test cases * fix: test cases (cherry picked from commit 8b7e153) # Conflicts: # erpnext/accounts/doctype/gl_entry/gl_entry.json # erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.json # erpnext/stock/report/test_reports.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solutions:
Result:
#no-docs