Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: production plan bom error #43591

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: production plan bom error #43591

merged 1 commit into from
Oct 9, 2024

Conversation

rohitwaghchaure
Copy link
Collaborator

Steps to replicate error

  • Create an Item A
  • Create a BOM against item A
  • Create the Sales Order and add Item A two times in the sales order
  • Create a new BOM against item A
  • Create a production plan against the above Sales Order
  • Fetch materials
  • Change the BOM for items
  • Click on "Consolidate Sales Order Items", you will get the below error
image

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 9, 2024
@rohitwaghchaure rohitwaghchaure added backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Oct 9, 2024
@rohitwaghchaure rohitwaghchaure merged commit ab17132 into frappe:develop Oct 9, 2024
18 checks passed
mergify bot pushed a commit that referenced this pull request Oct 9, 2024
@rohitwaghchaure @mergify
fix: production plan bom error (#43591)
9f35ae9 
(cherry picked from commit ab17132)
@mergify mergify bot mentioned this pull request Oct 9, 2024
Merged
rohitwaghchaure added a commit that referenced this pull request Oct 9, 2024
@mergify @rohitwaghchaure
fix: production plan bom error (backport #43591) (#43594)
029021f 
fix: production plan bom error (#43591)

(cherry picked from commit ab17132)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Oct 9, 2024
@frappe-bot
chore(release): Bumped to Version 15.38.1
d46cf46 
## [15.38.1](v15.38.0...v15.38.1) (2024-10-09)

### Bug Fixes

* 'NoneType' object has no attribute 'has_serial_no' (backport [#43514](#43514)) ([#43574](#43574)) ([60508a9](60508a9))
* [#42014](#42014) --resolve conflicts ([85d7405](85d7405))
* Accepted and Rejected warehouse cannot be same (backport [#43568](#43568)) ([#43573](#43573)) ([83ce3dd](83ce3dd))
* add include closed orders option in so/po trends report v15 ([5660e8b](5660e8b))
* add parenttype condition for item table in Purchase Register Report ([8ce81a0](8ce81a0))
* Add removed test code `https://github.com/frappe/erpnext/commit/b41f10c1b98b01a181a6f9dbdf2531b108dc3bae` ([30fd11f](30fd11f))
* allow to change the batch in the subcontracting receipt (backport [#43584](#43584)) ([#43588](#43588)) ([9e109ac](9e109ac))
* create Account Closing Balance even though there are no transaction in period ([d6f70f5](d6f70f5))
* creation of contact, customer, opportunity, quotation and prospect from lead ([ef10c4e](ef10c4e))
* creation of contact, customer, opportunity, quotation and prospect from lead --prettier ([5a2a404](5a2a404))
* deduct advances adjusted for threshold check for tcs ([6decb7c](6decb7c))
* do not include advances for tds vouchers ([ee8485a](ee8485a))
* frappe dependency update ([0a70b3f](0a70b3f))
* include parent item group in query ([55464c7](55464c7))
* make LCV button not working for PI and PR (backport [#43592](#43592)) ([#43593](#43593)) ([120b481](120b481))
* multiple issues in Payment Request ([#42427](#42427)) ([ea69ba7](ea69ba7))
* production plan bom error (backport [#43591](#43591)) ([#43594](#43594)) ([029021f](029021f))
* read only filters in multidialog fields (backport [#43503](#43503)) ([#43513](#43513)) ([d69a974](d69a974))
* Remove `advance_payment_status` uses ([907e3af](907e3af))
* Remove unreference method ([770bc1c](770bc1c))
* Remove unused  field ([e785928](e785928))
* Remove unused function `get_paid_amount_against_order` ([7591662](7591662))
* Separate `on_submit` and `before_submit` of PR ([dbd7b83](dbd7b83))
* the purchase receipt trends and delivery note trends report (backport [#43585](#43585)) ([#43587](#43587)) ([355ba2f](355ba2f))
* Unknown column 'serial_no' in 'field list' (backport [#43515](#43515)) ([#43569](#43569)) ([fc9a3c0](fc9a3c0))
* Update Values before `after_mapping` hook is called ([#42682](#42682)) ([6770610](6770610))
* validation for corrective job card (backport [#43555](#43555)) ([#43558](#43558)) ([cf0fa0d](cf0fa0d))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

Assignees
No one assigned
Labels
backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rohitwaghchaure