Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rounding for inclusive tax precision #43616

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: rounding for inclusive tax precision #43616

wants to merge 3 commits into from

Conversation

rtdany10
Copy link
Contributor

image

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Oct 11, 2024
nabinhait
nabinhait requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@nabinhait nabinhait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debit/credit mismatch error still comes if we enable "Disable Rounded Total" checkbox.

@stale Stale
Copy link

stale bot commented Oct 29, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 29, 2024
@stale stale bot closed this Nov 9, 2024
@nabinhait nabinhait reopened this Nov 11, 2024
@github-actions github-actions bot removed the needs-tests This PR needs automated unit-tests. label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

@nabinhait nabinhait Awaiting requested review from nabinhait

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
accounts inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtdany10 @nabinhait