fix: handle NoneType error when updating ordered_qty in SO for remove… #43762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavesh95863
requested review from
rohitwaghchaure and
s-aga-r
as code owners
ruthra-kumar
requested review from
ruthra-kumar
and removed request for
s-aga-r
|
Could you provide replication steps? |
|
@ruthra-kumar you can able to regenerate issue as per the steps mentioned in this issue. |
ruthra-kumar
force-pushed
the
fix-item-update
branch
from
cdf5ef8
to
442cdd7
Compare
ruthra-kumar
approved these changes
Nov 8, 2024
ruthra-kumar
added
backport version-14-hotfix
ruthra-kumar
added a commit
that referenced
this pull request
Nov 8, 2024
…-43762 fix: handle NoneType error when updating ordered_qty in SO for remove… (backport #43762)
ruthra-kumar
added a commit
that referenced
this pull request
Nov 8, 2024
…-43762 fix: handle NoneType error when updating ordered_qty in SO for remove… (backport #43762)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fallback to prevent
NoneTypeerror by settingprev_ordered_qtyto 0 if it is None.