fix: apply posting date sorting to invoices in Payment Reconciliation similar to payments #44089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… similar to payments
UmakanthKaspa
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
ruthra-kumar
approved these changes
Nov 15, 2024
ruthra-kumar
added
backport version-14-hotfix
ruthra-kumar
added a commit
that referenced
this pull request
Nov 15, 2024
…-44089 fix: apply posting date sorting to invoices in Payment Reconciliation similar to payments (backport #44089)
ruthra-kumar
added a commit
that referenced
this pull request
Nov 15, 2024
…-44089 fix: apply posting date sorting to invoices in Payment Reconciliation similar to payments (backport #44089)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the Payment Reconciliation tool, payment entries are ordered by their posting date, but the invoice entries were not.
This update adds sorting for invoice entries by their posting date in the
get_invoice_entriesfunction. The sorting of invoices is now aligned with the sorting applied to payments, ensuring consistency and improving the reconciliation process.Changes
Updated
get_invoice_entriesfunction to sortnon_reconciled_invoicesbyposting_date, similar to the sorting applied inget_nonreconciled_payment_entriesto sort payments.Screenshots
Before Sorting
After Sorting