Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Disable "Add Row" button in allocations table during UnReconcile process #44148

Conversation

UmakanthKaspa
Copy link
Contributor

Problem:

In the UnReconcile Allocations dialog, the cannot_add_rows property was incorrectly applied to the dialog itself, which did not prevent users from adding rows to the allocations table.

Solution:

The cannot_add_rows property has been moved and correctly applied to the allocations table field to disable the "Add Row" button, ensuring users cannot add new rows while reconciling

Before:

image

After:

image

@ruthra-kumar ruthra-kumar self-requested a review November 15, 2024 00:48
@ruthra-kumar ruthra-kumar self-assigned this Nov 15, 2024
@UmakanthKaspa UmakanthKaspa force-pushed the bugfix-disable-add-rows-allocations-table branch from c328060 to 13ca270 Compare November 15, 2024 04:09
@ruthra-kumar ruthra-kumar merged commit a16ab65 into frappe:develop Nov 15, 2024
11 checks passed
ruthra-kumar added a commit that referenced this pull request Nov 15, 2024
…-44148

Fix: Disable "Add Row" button in allocations table during UnReconcile process (backport #44148)
ruthra-kumar added a commit that referenced this pull request Nov 15, 2024
…-44148

Fix: Disable "Add Row" button in allocations table during UnReconcile process (backport #44148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants